I won't apply this version, please send v2 with the changes below. On Mon, 9 Nov 2026 20:06:57 +0100, Denis V. Lunev wrote: > ploop_worker() also goes to sleep with the flag set, as its sleep > condition checks the pio lists only. The held writes are retried only > when other I/O reaches the device: on a device whose only I/O is the > held writes, the writers stay in D state after the space is freed.
The code is fine, only the message needs two changes. - Item 4 of the cover letter reply: start a new paragraph at "The held writes are retried only...". The first paragraph then says what the code does and why that is wrong, the second what the user sees. > Wake the dispatcher from the timer, and keep ploop_worker() awake while > submit_enospc is set, so that a wakeup that comes while the dispatcher > is busy is not lost. Test and clear the flag with xchg() in > do_ploop_run_work(), as the timer now sets it from another CPU. - Item 3 of the cover letter reply: "now" is not right, drop the reason or give a true one. The timer has set the flag from softirq on any CPU since afc60480b037, this patch does not change that. The old test-then-clear lost nothing either, as ploop_resubmit_enospc_pios() takes the whole list after the clear. xchg() is fine as a cleanup, just without that clause. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
