Applying with these fixes on my side: - "merging physically adjacent ones into one discard" -> "merging those that follow each other both in the file and on disk into one discard" - "opened only through XFS_IOC_OPEN_BALLOON, which takes CAP_SYS_ADMIN, so the locks only wait for ploop" -> "only a privileged process opens it, through XFS_IOC_OPEN_BALLOON or a file handle, so in practice the locks wait only for ploop"
On Wed, 11 Nov 2026 12:31:35 +0100, Denis V. Lunev wrote: > its unwritten extents that fall into the requested range, merging > physically adjacent ones into one discard. The walk goes to the end of The run also ends at a hole, a written extent or an extent placed on disk before the one before it in the file, the same as on ext4. ploop fills the balloon from offset 0 and never writes it, so the code is fine and only the wording changes. > and opened only through XFS_IOC_OPEN_BALLOON, which takes > CAP_SYS_ADMIN, so the locks only wait for ploop inflating or shrinking > it. open_by_handle_at() and XFS_IOC_OPEN_BY_HANDLE open the balloon too. They need privileges as well, and the exclusive locks cover any opener, so only the wording changes. > + /* > + * Chunks keep a long run interruptible. They end on multiples of the > + * discard granularity, so no cluster below is split between two. > + */ Item 2 of the cover letter reply. > + error = blkdev_issue_discard(bdev, daddr, next - daddr, > + GFP_KERNEL); > + if (error) > + return error; Item 1 of the cover letter reply. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
