Applying with these fixes on my side:
- subject: "Pin the hogs" -> "pin the hogs", lowercase after the
  prefix.

Asks, not needed for this patch:
- Send it to mainline too, see the task below.
- Say whether test_cpucg_nested_weight_overprovisioned passes on the
  same NUMA host; if it does not, pin its hogs in a separate patch.

On Thu, 12 Nov 2026 06:23:20 +0200, Eva Kurchatova wrote:
> Pin the hogs of each cgroup one per CPU: the test checks the weights,
> not the load balancer.

This needs to go to mainline too, I created a task for that:
https://virtuozzo.atlassian.net/browse/VSTOR-154829

Mainline v7.4-rc1 has the same unpinned hog_cpus_timed(), so the test
fails there on the same hosts. For the mainline version, take Sashiko's
pthread_attr_destroy() remark: init the attr only when pinning, pass
NULL otherwise and destroy it after the loop. Upstream reviewers will
ask for it.

> -     return weight_hog_ncpus(child, get_nprocs());
> +     return weight_hog_ncpus(child, get_nprocs(), true);

run_cpucg_nested_weight_test() with overprovisioned set starts
get_nprocs() unpinned hogs in each of its three leaves through the same
hog_cpus_timed(), so the reasoning of this patch applies to it as well.
Its tolerance is wider in practice, which may be why it has not failed
yet. ".pin = overprovisioned" in its param would cover it; the
underprovisioned cases must stay unpinned, or all hogs land on the
first CPUs of the mask.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to