On 11/13/26 20:41, Konstantin Khorenko wrote:
> 1. Patch 1, code: a restored ring below this node's minimum must not
>    lose slots in the per-CPU caches. E.g. mark such a context in
>    ioctx_alloc() and let put_reqs_available() and
>    __get_reqs_available() use ctx->reqs_available directly for it.
>    If you keep the cache, the commit message must state the real
>    bound instead of "slightly less reliable".

Done as you suggest: ioctx_alloc() sets ctx->no_percpu_reqs when it
skips the heuristic and the heuristic would have made the ring bigger,
and put_reqs_available() and __get_reqs_available() then use only
ctx->reqs_available. All slots of such a ring stay usable, as on the
source node. struct kioctx is private to fs/aio.c, and the bool takes
the hole after req_batch, so its size doesn't change.

> 2. Patch 1, commit message and comment: the VE is pseudosuper not only
>    for the restore. vzctl sets ve.pseudosuper on every CT start and
>    clears it just before it execs init. Say "while the CT is being
>    started or restored", or similar.

Changed to "which it is almost only for the restore". No AIO runs in
the CT start window, so the skip matters only for the restore, and I'd
rather not spell out the start details there.

> 3. Patch 1, commit message: say what fails without the patch: CRIU's
>    restore_aio_ring() reports "wrong aio" and the migration is
>    aborted.

Not changed: the message already says that CRIU needs a ring of the same
size and that with a bigger ring the restore fails.

> 4. Patch 2: read the CPU count from /sys/devices/system/cpu/possible,
>    the mask the kernel uses, not sysconf(_SC_NPROCESSORS_CONF).

Not changed: on vz10 glibc (2.39) sysconf(_SC_NPROCESSORS_CONF) already
reads /sys/devices/system/cpu/possible (checked with strace), so it is
the same mask.

> 5. Patch 2: do not leave the VE cgroup behind when FIXTURE_SETUP fails
>    after make_ve(), and use ASSERT_EQ for set_pseudosuper().

Done, both.

-- 
Best regards, Pavel Tikhomirov
Senior Software Developer, Virtuozzo.

_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to