Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] selftests/bpf: xsk bitmap fix lacks Fixes: trailers --
commit ee0829e53ca566bede00c40365c639ece9f4e9bd Author: Bastien Curutchet (eBPF Foundation) <[email protected]> > ms/selftests/bpf: test_xsk: Initialize bitmap before use > > bitmap is used before being initialized. > > Initialize it to zero before using it. > > Reviewed-by: Maciej Fijalkowski <[email protected]> > Signed-off-by: Bastien Curutchet (eBPF Foundation) > <[email protected]> > Link: https://lore.kernel.org/r/[email protected] > Signed-off-by: Alexei Starovoitov <[email protected]> > (cherry picked from commit 2233ef8bba81e02e8fee6300a81dcf389aa17c58) > > Rebase note: applied to xskxceiver.c. Mainline moved this code to > test_xsk.c in commit 3ab77f35a75e ("selftests/bpf: test_xsk: Split > xskxceiver"), which is not here. The code is the same. > > https://virtuozzo.atlassian.net/browse/VSTOR-154851 > Feature: fix selftests > > Signed-off-by: Eva Kurchatova <[email protected]> [Severity: Low] This fixes reads of an uninitialized on-stack bitmap in receive_pkts() and send_pkts(), but the message has no Fixes: tags. Should it include the commits that introduced the two bugs? Fixes: 8913e653e9b8 ("selftests/xsk: Iterate over all the sockets in the receive pkts function") Fixes: fd0815ae9b8a ("selftests/xsk: Iterate over all the sockets in the send pkts function") -- Sashiko AI review ยท https://sashiko.vzint.dev/#/patchset/[email protected]?part=1 _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
