From: Denis V. Lunev <[email protected]>

ve_offline() frees ve->ve_name as soon as the ve cgroup goes offline,
while the ve itself lives on as long as anything holds a reference, a
ve namespace for one. Tasks of that namespace still point at the ve,
and readers of another task's ve name, such as sched_show_task(),
dereference the string with nothing that keeps it from being freed
under them. A reference to the ve does not help either, as it does not
hold the cgroup online.

Free the name in ve_destroy() instead. That is css_free, which runs
after an RCU grace period, so the name is valid for as long as the ve
is and an RCU reader of task_ve() can print it. ve0 is never destroyed
and keeps its static name. ve_offline() is left empty and goes away.

https://virtuozzo.atlassian.net/browse/VSTOR-155341

Feature: ve: ve generic structures
Suggested-by: Vasileios Almpanis <[email protected]>
Signed-off-by: Denis V. Lunev <[email protected]>
---
 kernel/ve/ve.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/kernel/ve/ve.c b/kernel/ve/ve.c
index 6cdfaaa4e703..cdfd03416b39 100644
--- a/kernel/ve/ve.c
+++ b/kernel/ve/ve.c
@@ -894,16 +894,6 @@ static int ve_online(struct cgroup_subsys_state *css)
        return 0;
 }
 
-static void ve_offline(struct cgroup_subsys_state *css)
-{
-       struct ve_struct *ve = css_to_ve(css);
-
-       if (!ve_is_super(ve)) {
-               kfree(ve->ve_name);
-               ve->ve_name = NULL;
-       }
-}
-
 static void ve_devmnt_free(struct ve_devmnt *devmnt)
 {
        if (!devmnt)
@@ -939,6 +929,7 @@ static void ve_destroy(struct cgroup_subsys_state *css)
        ve_free_vdso(ve);
        mntput(ve->devtmpfs_mnt);
        free_percpu(ve->sched_lat_ve.cur);
+       kfree(ve->ve_name);
        ve_set_state(ve, VE_STATE_DEAD);
        kmem_cache_free(ve_cachep, ve);
 }
@@ -1690,7 +1681,6 @@ static struct cftype ve_cftypes[] = {
 struct cgroup_subsys ve_cgrp_subsys = {
        .css_alloc      = ve_create,
        .css_online     = ve_online,
-       .css_offline    = ve_offline,
        .css_free       = ve_destroy,
        .legacy_cftypes = ve_cftypes,
        .dfl_cftypes    = ve_cftypes,
-- 
2.55.0

_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to