Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] dm-qcow2: bug-fix commit lacks a Fixes: trailer for the unconditional timer rearm --
commit f6ae30bd65b89326d336e21edcc9fd1610542f23 Author: Alexander Ivanov <[email protected]> > drivers/md/dm-qcow2: arm the hold timer only for the first held request > > Every held request rearms tgt->held_timer, so while new requests keep > failing the held ones are never retried. A guest that keeps writing to > a full disk is enough to postpone the retry indefinitely. > > Arm the timer when the held list turns non-empty, so the held requests > are retried a fixed period after the first of them failed. > > https://virtuozzo.atlassian.net/browse/VSTOR-152175 > Feature: dm-qcow2: block device over QCOW2 files driver > Signed-off-by: Alexander Ivanov <[email protected]> [Severity: Low] This reads as a bug fix: the unconditional mod_timer() came in with the original ENOSPC handling, and a guest that keeps failing writes can postpone the retry forever. Should this carry a Fixes: tag, for example: Fixes: 6e2ec304689f ("dm-qcow2: Pause IO and notify about ENOSPC events") -- Sashiko AI review ยท https://sashiko.vzint.dev/#/patchset/[email protected]?part=4 _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
