Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] commit message: Signed-off-by name has organisation tag '(NGI0)' --
commit df84538a8d8ad307de4869b8e2892420245975fb Author: Paolo Abeni <[email protected]> ms/mptcp: explicitly drop over memory limits This commit makes __mptcp_move_skb() drop an incoming skb when the msk is over its receive memory limit, instead of leaving it in the subflow queue. The loops that move skbs from the subflows now stop over the limit only for a fallback socket. > ms/mptcp: explicitly drop over memory limits > > Currently the enforcement of the rcvbuf constraint is implemented > when moving the skbs into the msk receive or OoO queue, keeping the > incoming skbs in the subflow queue when over limits. > > Under significant memory pressure the above can cause permanent data > transfer stalls, as the skb needed to make forward progress can be > stuck in a subflow queue. > > Over memory limits, drop the incoming skb, relying on MPTCP-level > retransmissions. > > Note that fallback socket must perform the limit before the skb reaches > the subflow-level queue, as dropping an in-sequence already acked skb > would break the stream. > > This is not a complete fix for the stall issue, as the drop strategy > needs refinements that will come in the next patches. > > Signed-off-by: Paolo Abeni <[email protected]> > Reviewed-by: Matthieu Baerts (NGI0) <[email protected]> > Signed-off-by: Matthieu Baerts (NGI0) <[email protected]> > Link: > https://patch.msgid.link/20260807-net-next-mptcp-oooq-pruning-v3-4-dbc1eb853...@kernel.org > Signed-off-by: Jakub Kicinski <[email protected]> > (cherry picked from commit e0e4d56b050597a690b4dd1c281af532469b0636) > > Rebase note: this tree has no MPTCP-level backlog, its receive path > moves the skbs from the subflow queue straight to the msk. The drop goes > into __mptcp_move_skb(), and the loops that move the skbs stop over the > limits only for a fallback socket, which keeps them in the subflow queue > as before. The options.c check that drops them for a fallback socket > before that queue, and the BacklogDrop counter, are left out; RcvPruned > is already there. > > Signed-off-by: Eva Kurchatova <[email protected]> [Severity: High] Is the name in the trailer "Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>" what is meant to appear in the chain? The parenthesised organisation tag "(NGI0)" is not part of a plain real name. Should the Signed-off-by (and the matching Reviewed-by) use just the name, "Matthieu Baerts <[email protected]>"? -- Sashiko AI review ยท https://sashiko.vzint.dev/#/patchset/[email protected]?part=8 _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
