Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] Fixes trailer lacks parentheses around the quoted subject
--

commit 19e003c422eeb3e947b70fcf695dd6a60f9073e4
Author: Al Viro <[email protected]>

ms/tracefs: fix a leak in eventfs_create_events_dir()

This commit moves the tracefs_start_creating() call in 
eventfs_create_events_dir() to after the security_locked_down(LOCKDOWN_TRACEFS) 
check. A lockdown bail-out then no longer leaves the parent directory locked.

> ms/tracefs: fix a leak in eventfs_create_events_dir()
>
> [ Upstream commit 798a401660a151633cb171738a72a8f1efb9b0b4 ]
>
> If we have LOCKDOWN_TRACEFS, the function bails out - *after*
> having locked the parent directory and without bothering to
> undo that.  Just check it before tracefs_start_creating()...
>
> Fixes: e24709454c45 "tracefs/eventfs: Add missing lockdown checks"
> Acked-by: Steven Rostedt (Google) <[email protected]>
> Signed-off-by: Al Viro <[email protected]>
> Signed-off-by: Sasha Levin <[email protected]>
> (cherry picked from commit 3bcb274a192fc89a003a7808a877faf1f9a81ce3)
>
> https://virtuozzo.atlassian.net/browse/VSTOR-155413
> Feature: fix ms/tracefs
>
> Signed-off-by: Eva Kurchatova <[email protected]>

[Severity: Low]
This isn't a functional problem, but the Fixes: trailer is malformed. The 
subject is not enclosed in parentheses, so Fixes-parsing tooling may not 
recognise it. Should it read:

  Fixes: e24709454c45 ("tracefs/eventfs: Add missing lockdown checks")

-- 
Sashiko AI review ยท 
https://sashiko.vzint.dev/#/patchset/[email protected]?part=1

_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to