> It has had no caller since commit 3c6e0c1ac1d6 ("mm/memcontrol: use
> lruvec_del_folio() in memcg_numa_isolate_pages()"), and being static
> __always_inline it never drew a warning.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-152197
> 
> Feature: mm: interface to migrate memory between NUMA nodes upon userspace 
> request

Should it also have:
Fixes: 810e6836a6dc9 ("mm/memcontrol: use lruvec_del_folio() in 
memcg_numa_isolate_pages()")

> Signed-off-by: Konstantin Khorenko <[email protected]>
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index d8a87913ace37..a82d5e7bc8694 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -3497,24 +3497,6 @@ static struct folio 
> *memcg_numa_migrate_new_folio(struct folio *old_folio,
>                            ms->target_nodes);
>  }
>  
> -/*
> - * Update LRU sizes after isolating pages. The LRU size updates must
> - * be complete before mem_cgroup_update_lru_size due to a santity check.
> - */
> -static __always_inline void update_lru_sizes(struct lruvec *lruvec,
> -                     enum lru_list lru, unsigned long *nr_zone_taken)
> -{
> -     int zid;
> -
> -     for (zid = 0; zid < MAX_NR_ZONES; zid++) {
> -             if (!nr_zone_taken[zid])
> -                     continue;
> -
> -             update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]);
> -     }
> -
> -}
> -
>  /*
>   * Isolate at most @nr_to_scan pages from @lruvec for further migration and
>   * store them in @dst. Returns the number of pages scanned. Return value of 0

Reviewed-by: Pavel Tikhomirov <[email protected]>

-- 
Pavel Tikhomirov <[email protected]>
_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to