I won't apply this version, please send v3 with the changes below.

On Tue, 17 Nov 2026 14:13:20 +0400, Mirian Shilakadze wrote:
> This series marks the tasks the host sends into a starting VE as setup
> tasks. Fork keeps the mark, exec drops it, and only a task coming from
> the host gets it.

All seven v1 items are done, and the 1/6 reordering of ve_setup_task()
and the namespace put is right. What is left:

1. Patch 3, code: a host task that entered a starting VE and moves on
   to a running VE only after the first one cleared pseudosuper is no
   longer hidden there. ve_vps_dumpable(mm, old_ve) is then
   VD_PTRACE_COREDUMP, so nothing marks the mm, and the root of the
   running VE can read the task's fds. Before the series it got
   VD_VE_ENTER_TASK. Your test hops before the clear. Either close it
   or say in the 3/6 message that this case is not covered and why.

2. Patch 5, code: ve_try_reserve_mount() still checks ve_is_super(ve)
   in front of ve_current_is_host_task(), which is already true for
   ve0, and the comment below still says "pseudosuper cases" (Sashiko
   asked too).

3. Small text fixes: the second paragraph of the 3/6 message has five
   sentences, put the new one about tasks leaving a pseudosuper VE in
   its own; "one have to be" -> "one has to be" in the 4/6 comment;
   "ve0 never leaves it" in the ve_vps_dumpable() kernel-doc reads as
   the opposite of what the code does with ve0.

4. Cover letter change log: "a task that setns()es into its own VE
   keeps its mark" is not new, v1 kept it too.

Thanks.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to