On 02/23, Nir Soffer wrote: > ----- Original Message ----- > > From: "David Caro" <dcaro...@redhat.com> > > To: devel@ovirt.org > > Sent: Monday, February 23, 2015 12:54:26 PM > > Subject: Re: [ovirt-devel] Gerrit restart > > > > > > I've done a few tests now and everything seems to work as expected, can > > anyone > > confirm that it's working for him? > > It seem to work but there are few issues: > > 1. Vertical and horizontal scrolling in the commit message pane > The new version assume that the commit message is limited to > about 70 characters, which is not true practically. > The commit message must include sometimes much wider content, > and the view should display correctly our data instead of > trying to force the views of the tool authors. > Example: http://gerrit.ovirt.org/36593
This has always been like that as far as I remember. Not a new issue. Actually now it allows you to scroll instead of letting the text go all the way out the screen, I think it's an improvement. > > 2. The changes view (http://gerrit.ovirt.org/#/dashboard/self) > Show a new "Status" column, which has two issues: > - Showing "Draft" or "Merge Conflict" - these are separate > concepts That's a design decision, nothing we can do about. Feel free to develop a ui plugin to hide it if it bothers you, this new version allows it (the old did not). > - Showing "Merge Conflict" when there is no merge conflict > Example: http://gerrit.ovirt.org/38044 You can't cherry-pick that patch into master directly (vdsm project submit type is cherry-pick): 01:16 PM ~/Work/redhat/ovirt/vdsm (master|✔) dcaro@brete$ git fetch ssh://dc...@gerrit.ovirt.org:29418/vdsm refs/changes/28/38028/1 remote: Counting objects: 745, done remote: Finding sources: 100% (29/29) remote: Total 29 (delta 3), reused 9 (delta 3) Unpacking objects: 100% (29/29), done. From ssh://gerrit.ovirt.org:29418/vdsm * branch refs/changes/28/38028/1 -> FETCH_HEAD 01:16 PM ~/Work/redhat/ovirt/vdsm (master|✔) dcaro@brete$ git cherry-pick FETCH_HEAD error: could not apply 53f59a7... virt: Extract Vm.__extendDriveReplica method hint: after resolving the conflicts, mark the corrected paths hint: with 'git add <paths>' or 'git rm <paths>' hint: and commit the result with 'git commit' 01:17 PM ~/Work/redhat/ovirt/vdsm (master|✖ 1✚ 1) dcaro@brete$ > > 3. The new "Conflict with" pane seems incorrect about patches > which do not conflict (at least not when merged in the correct > order of dependencies). > Example: http://gerrit.ovirt.org/37727 I don't think it's taking into account the deps, the conflict seems to be calculated from path to path directly. Feel free to open a but to gerrit if you think any of those issues should not be there or it's a bug. https://code.google.com/p/gerrit/issues/list > > So this seems to be a regression. Can we test such upgrades > with our data before we deploy them? > Sure, I'll ping you to do the testing next time we plan an upgrade, I'll have to trim down some of the data but I'll gladly spend some time on it to provide you with a working dataset you can install and test before the upgrade. > > Nir > > > > > If noone replies, I'll consider it solved > > > > cheers > > > > On 02/23, David Caro wrote: > > > > > > Hi! > > > > > > After this morning upgrade, gerrit http access has stopped working, I'm > > > trying > > > to solve it but in the meantime I might have to restart gerrit a couple of > > > times, you can still use git or ssh to clone repos. > > > > > > > > > I'll update when finished. > > > > > > > > > > > > > > > -- > > > David Caro > > > > > > Red Hat S.L. > > > Continuous Integration Engineer - EMEA ENG Virtualization R&D > > > > > > Tel.: +420 532 294 605 > > > Email: dc...@redhat.com > > > Web: www.redhat.com > > > RHT Global #: 82-62605 > > > > > > > > -- > > David Caro > > > > Red Hat S.L. > > Continuous Integration Engineer - EMEA ENG Virtualization R&D > > > > Tel.: +420 532 294 605 > > Email: dc...@redhat.com > > Web: www.redhat.com > > RHT Global #: 82-62605 > > > > _______________________________________________ > > Devel mailing list > > Devel@ovirt.org > > http://lists.ovirt.org/mailman/listinfo/devel -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605
pgpw7m6KjpCgf.pgp
Description: PGP signature
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
