----- Original Message ----- > Hi, > > very first question which comes to mind > is: will vdsm hooks which alter the libvirt xml > still work? > > I believe this is a much used feature > and if it would not work anymore out of the box > this would be a huge pain in upgrading existing systems.
Yes, the hooks will still work. Please look at my response to didi regarding VDSM hooks. > > furthermore I don't really see the benfits when you generate > the xml in engine: > > you still need to alter it in vdsm as you write, to fill in host > specific things like storagepaths anyway, meaning you have to maintain > twice the codebase _and_ coordinate between the two of them, so nothing > goes wrong if one project changes something in the xml. The removal of the code that is being executed before the hooks are called which creates the XML from the VM properties map would justify the effort. Once VDSM will support only the new API (of getting Libvirt XML as an input) this code could be removed. > > but this are just my 2 cent :-) > > > -- > Mit freundlichen Grüßen / Regards > > Sven Kieske > > Systemadministrator > Mittwald CM Service GmbH & Co. KG > Königsberger Straße 6 > 32339 Espelkamp > T: +495772 293100 > F: +495772 293333 > https://www.mittwald.de > Geschäftsführer: Robert Meyer > St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen > Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen > > > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
