On Thu, Feb 14, 2019 at 7:51 PM Tian Xu <tian...@oracle.com> wrote:
>
> Hi Experts,
>
> I am trying to run ovirt-system-test in my local lab, which need proxy
> to access internet. ovirt cannot work with proxy to access ovirt glance
> repository, whose URL is: http://glance.ovirt.org:9292, a related
> bugzilla was filed by someone and in open status:
> https://bugzilla.redhat.com/show_bug.cgi?id=1362433

Well, patches are most welcome. I suspect that one should go to
https://github.com/woorea/openstack-java-sdk and another - to make
this configurable in ovirt-engine-setup.

>
> Some ovirt system tests depend on ovirt glance repository for VM images,
> these tests either skipped or failed, then subsequent VM related tests
> cannot be run. Here is the test file:
> https://github.com/oVirt/ovirt-system-tests/blob/master/basic-suite-4.2/test-scenarios/004_basic_sanity.py,
> and the verify_glance_import failed, then other test blocked too.

I think that we are not being consistent here. snapshot_cold_merge
seems to be skipped if Glance is unreachable, yet verify_glance_import
fails the whole suite loudly.
I'd prefer to so a OST_SKIP_GLANCE environment variable is used to
control if these tests are attempted. Then, if you do not care for
Glance, you can simply drop it.

Theoretically you can raise a SkipTest() from verify_glance_import.
However, tryng and skipping is not a good practice. It leads to false
negatives: production code can break without anyone noticing that the
tests are skipped.

>
> Below is exception message and details test log see attachment.
>
>
> Running test scenario 004_basic_sanity.py
> <?xml version="1.0" encoding="UTF-8"?>
> <testsuite name="nosetests" tests="3" errors="1" failures="0" skip="1">
>    <testcase classname="004_basic_sanity" name="add_blank_vms"
> time="2.473"/>
>    <testcase classname="004_basic_sanity" name="verify_glance_import"
> time="0.050">
>      <skipped type="unittest.case.SkipTest" message="Glance is not
> available"><![CDATA[SkipTest: Glance is not available
> ]]></skipped>
>    </testcase>
>    <testcase classname="004_basic_sanity" name="add_vm1_from_template"
> time="0.266">
>      <error type="exceptions.IndexError" message="list index out of
> range"><![CDATA[Traceback (most recent call last):
>    File "/usr/lib64/python2.7/unittest/case.py", line 369, in run
>      testMethod()
>    File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in
> runTest
>      self.test(*self.arg)
>    File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
> 142, in wrapped_test
>      test()
>    File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
> 60, in wrapper
>      return func(get_test_prefix(), *args, **kwargs)
>    File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line
> 79, in wrapper
>      prefix.virt_env.engine_vm().get_api(api_ver=4), *args, **kwargs
>    File
> "/mnt/zz/bak/ovirt-system-tests-master/basic-suite-4.2/test-scenarios/004_basic_sanity.py",
> line 748, in add_vm1_from_template
>      )[0]
> IndexError: list index out of range
> ]]></error>
>    </testcase>
> </testsuite>
>
> Thanks,
>
> Xu
>
> _______________________________________________
> Devel mailing list -- devel@ovirt.org
> To unsubscribe send an email to devel-le...@ovirt.org
> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct: 
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives: 
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/ZQRRCNOHIO52BXIPCS342L6FWVGUJNZ2/
_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/QBVJAWYSBOHG7OWHIEJN2UNLPU7BN7KX/

Reply via email to