Hi,
looking at ovirt-engine CI automation scripts, I see:
export EXTRA_BUILD_FLAGS="-gs $MAVEN_SETTINGS \
-Dovirt.surefire.reportsDirectory=${PWD}/exported-artifacts/tests \
"
But looking at exported data, there's no exported-artifacts/tests directory.
Looking at build execution I see:
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @
ovirt-findbugs-filters ---
[INFO] Tests are skipped.
...
[INFO] --- maven-surefire-plugin:2.22.0:test (default-test) @ checkstyles ---
[INFO] Tests are skipped.
and so on.
This is due to the build happening with
RPM_BUILD_MODE="ovirt_build_quick"
which cause the setting of %global _ovirt_build_ut 0
which set BUILD_UT=0
which skip all tests due to:
ifeq ($(BUILD_UT),0)
BUILD_FLAGS:=$(BUILD_FLAGS) -D skipTests
endif
Also, check patch has:
# Since spotbugs is a pure java task, there's no reason to run it on
multiple
# platforms.
# Spotbugs currently has false negatives using mvn 3.5.0, which is the
currnt centos version from SCL (rh-maven35).
# We will work with the Fedora version meanwhile which has maven 3.5.4 and
is known to work.
if [[ "$STD_CI_DISTRO" =~ "fc" ]]; then
source automation/spotbugs.sh
fi
so spotbugs is executed only on Fedora but then:
if [[ "$STD_CI_DISTRO" = "el7" ]]; then
# Collect any mvn spotbugs artifacts
mkdir -p exported-artifacts/find-bugs
find * -name "*spotbugs.xml" -o -name "spotbugsXml.xml" | \
while read source_file; do
destination_file=$(
sed -e 's#/#-#g' -e 's#\(.*\)-#\1.#' <<< "$source_file"
)
mv $source_file exported-artifacts/find-bugs/"$destination_file"
done
mv ./*tar.gz exported-artifacts/
fi
so assuming we re-enable tests there, results are collected only on el7
meaning we are never getting results of this test.
Can we decide what we really want check-patch to do?
Either we want test results and we should enable proper build including
tests or we should drop all of this broken test result collection code.
--
Sandro Bonazzola
MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV
Red Hat EMEA <https://www.redhat.com/>
sbona...@redhat.com
<https://www.redhat.com/>*Red Hat respects your work life balance.
Therefore there is no need to answer this email out of your office hours.*
_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
List Archives:
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/IVMUHOQ7BHN43P7CNAEV735NNCLATJB7/
