On Wed, Sep 9, 2020 at 2:11 PM Benny Zlotnik <[email protected]> wrote:
>
> IIRC the issue is the rules are different for fedora and centos, so we
> had to make it comply with centos to avoid breaking CI, the workaround
> is to just remove isort from the development machine
I think you can also run
make ISORT=nonexistent ...
Because the code calling it checks:
if ! which "${ISORT}" > /dev/null 2>&1; then
>
> On Wed, Sep 9, 2020 at 2:02 PM Prajith Kesava Prasad
> <[email protected]> wrote:
> >
> > Hi,
> >
> > everytime i clone and run make install i get this error, as a workaround i
> > remove them and re-run which works fine, but i wanted to know the root
> > cause, i thought it was because i pulled a wrong head ref?, or is it a
> > common issue?
> > ```
> > packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaajdbc.py:249:21
> > '...'.format(...) has unused named argument(s): profile
> > packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/auth_url_validation.py:75:13
> > '...'.format(...) has unused named argument(s): ownConnection
> > + echo ERROR: The following check failed:
> > ERROR: The following check failed:
> > ```
This does not look like an isort issue, but a pep8/codestyle/pyflakes one.
Now reproduced (had to upgrade my virtualenv-/pip-installed
pycodestyle for this).
I'll push a patch later.
> >
> >
> > Regards,
> > Prajith
> > _______________________________________________
> > Devel mailing list -- [email protected]
> > To unsubscribe send an email to [email protected]
> > Privacy Statement: https://www.ovirt.org/privacy-policy.html
> > oVirt Code of Conduct:
> > https://www.ovirt.org/community/about/community-guidelines/
> > List Archives:
> > https://lists.ovirt.org/archives/list/[email protected]/message/BEEW6XOPFQMAKIV26U5O6IQG4DQ6LGO3/
> _______________________________________________
> Devel mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
> Privacy Statement: https://www.ovirt.org/privacy-policy.html
> oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives:
> https://lists.ovirt.org/archives/list/[email protected]/message/K6U6A3PPCW6IZ7Z6D22QTWIA72WLCFYK/
--
Didi
_______________________________________________
Devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
List Archives:
https://lists.ovirt.org/archives/list/[email protected]/message/HRZZ3BO3K42EE5SC55LIDDGOYHDA3YGG/
