On 2/1/22 09:58, Denis Volkov wrote:
Hello Marcin

Sorry for the late reply

I will try checking if that feature can be disabled. Meanwhile I think you could use the `comments` url to get the comments directly: `curl -s -L https://gerrit.ovirt.org/changes/118398/comments|sed <https://gerrit.ovirt.org/changes/118398/comments|sed> 1d|jq '.'` If needed, field `change_message_id` can be used to link message in `details` and `comments` URLs

Hi, yeah, I was able to use the /comments endpoint for my purposes,
so we can stick with comment chips (although I still find them really weird :) ).

Thanks, Marcin



On Mon, Jan 31, 2022 at 12:32 PM Marcin Sobczyk <msobc...@redhat.com <mailto:msobc...@redhat.com>> wrote:

    Hi,

    thanks for handling the upgrade.

    With the new version it's not possible anymore to get contents of the
    comments which we need for OST gating.

    i.e. for this patch:

    https://gerrit.ovirt.org/c/ovirt-system-tests/+/118398
    <https://gerrit.ovirt.org/c/ovirt-system-tests/+/118398>

    if you try:

    curl -L https://gerrit.ovirt.org/changes/118398/detail
    <https://gerrit.ovirt.org/changes/118398/detail> | \
          sed 1d | \
          jq -r '.messages[]'

    you'll see for one of my last comments:

    ...
    "message": "Patch Set 1:\n\n(1 comment)"
    ...

    but there's no "ci ost" string, which is what I actually wrote.

    It's probably because of the new "comment chips" feature.
    If it's possible and there are no objections could you please try
    turning it off?

    Regards, Marcin


    On 1/28/22 18:48, Denis Volkov wrote:
     > Hello
     >
     > Upgrade to version 3.4.3 is finished. Gerrit is up and running.
     >
     > In case of issues please create ticket in issue tracking system:
     > https://issues.redhat.com/projects/CPDEVOPS/issues
    <https://issues.redhat.com/projects/CPDEVOPS/issues>
     > <https://issues.redhat.com/projects/CPDEVOPS/issues
    <https://issues.redhat.com/projects/CPDEVOPS/issues>>
     >
     > --
     >
     > Denis Volkov
     >
     >
     >
     > _______________________________________________
     > Users mailing list -- us...@ovirt.org <mailto:us...@ovirt.org>
     > To unsubscribe send an email to users-le...@ovirt.org
    <mailto:users-le...@ovirt.org>
     > Privacy Statement: https://www.ovirt.org/privacy-policy.html
    <https://www.ovirt.org/privacy-policy.html>
     > oVirt Code of Conduct:
    https://www.ovirt.org/community/about/community-guidelines/
    <https://www.ovirt.org/community/about/community-guidelines/>
     > List Archives:
    
https://lists.ovirt.org/archives/list/us...@ovirt.org/message/I676ITKOHKLH4Q7CMRGVSYHYYTPKKHXA/
    
<https://lists.ovirt.org/archives/list/us...@ovirt.org/message/I676ITKOHKLH4Q7CMRGVSYHYYTPKKHXA/>



--

Denis Volkov

Red Hat <https://www.redhat.com>

<https://www.redhat.com>

_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/4QQKN27UYE3B3H2NDWIRTZYAZBTIGG4X/

Reply via email to