Hi Hasan, can you open a Pull Request on GitHub, so we can review and discuss your port there?
2014-12-22 10:41 GMT+01:00 Islam Hasan <hasan.is...@aalto.fi>: > Hi, > > I have included microcoap as an external pkg in RIOT OS, but getting some > frustrating warnings from RIOT as the followings: > > /RIOT/pkg/microcoap/microcoap/coap.c:68:26: warning: comparison between > signed and unsigned integer expressions [-Wsign-compare] > if (4 + hdr->tkl > buflen) > There is an implicit casting going on here, since 4 is signed, and hdr->tkl and buflen are unsigned. Use 4U instead of 4, so 4 is unsigned, too. > > /RIOT/pkg/microcoap/microcoap/coap.c:354:5: warning: comparison is always > true due to limited range of data type [-Wtype-limits] > if (value<=0xFF+13) > ^ > 0xFF is the maximum of uint8_t… I'm not quiet sure what the use-case for all of the if-statements in that function are for, maybe you get in touch with the microcoap authors for that. > > However, I was looking for libcoap example application in RIOT, for > instance, testing a client application with microcoap server. I notice that > RIOT has supports for libcoap, but no example application there to play > with it. > The ETSI coap plugtests are currently under review as an example application: https://github.com/RIOT-OS/RIOT/pull/1801. Hope I could help, Martine
_______________________________________________ devel mailing list devel@riot-os.org http://lists.riot-os.org/mailman/listinfo/devel
