Hi Initial quick feedback. I build normally with --enable-rtems-debug and the tms570ls3137_hdk variant failed to build with this failure:
arm-rtems4.11-gcc --pipe -DHAVE_CONFIG_H -I../../.. -I../../../../cpukit/../../../tms570ls3137_hdk/lib/include -DASM -march=armv7-r -mthumb -mbig-endian -O2 -ggdb3 -DNDEBUG -Wall -Wmissing-prototypes -Wimplicit-function-declaration -Wstrict-prototypes -Wnested-externs -march=armv7-r -mthumb -mbig-endian -O2 -ggdb3 -DNDEBUG -Wall -Wmissing-prototypes -Wimplicit-function-declaration -Wstrict-prototypes -Wnested-externs -MT libscorecpu_a-arm-context-volatile-clobber.o -MD -MP -MF .deps/libscorecpu_a-arm-context-volatile-clobber.Tpo -c -o libscorecpu_a-arm-context-volatile-clobber.o `test -f 'arm-context-volatile-clobber.S' || echo '../../../../../../../../rtems/c/src/../../cpukit/score/cpu/arm/'`arm-context-volatile-clobber.S mv -f .deps/libscorecpu_a-arm-context-volatile-clobber.Tpo .deps/libscorecpu_a-arm-context-volatile-clobber.Po In file included from ../../../../cpukit/../../../tms570ls3137_hdk/lib/include/rtems/score/percpu.h:25:0, from ../../../../cpukit/../../../tms570ls3137_hdk/lib/include/rtems/system.h:23, from ../../../../../../../../rtems/c/src/../../cpukit/score/cpu/arm/cpu.c:29: ../../../../cpukit/../../../tms570ls3137_hdk/lib/include/rtems/score/isrlock.h: In function '_ISR_lock_ISR_disable_and_acquire': ../../../../cpukit/../../../tms570ls3137_hdk/lib/include/rtems/score/assert.h:38:46: error: '__ASSERT_FUNC' undeclared (first use in this function) __assert_func( __FILE__, __LINE__, __ASSERT_FUNC, #_e ) ) ^ Since there was some work to add a new ARM variant, I am suspicious that a .h file is missing when this is compiled for Rx ARM variants. I didn't build other variants and am trying again with debug disabled. More to follow. --joel On 8/20/2014 12:30 PM, Joel Sherrill wrote: > I replied to a private message without everyone on it. > > Premysl. Can you submit the final patch so I am sure I am > merging the right thing? > > Thanks. > > --joel > On 8/20/2014 12:28 PM, Gedare Bloom wrote: >> All, >> Pavel has indicated no warnings and no serious problems flagged by >> check_submission. >> >> I'm OK with this patch, Joel commit if you also approve. >> >> -Gedare >> >> On Wed, Aug 20, 2014 at 11:47 AM, Joel Sherrill >> <joel.sherr...@oarcorp.com> wrote: >>> On August 20, 2014 10:39:06 AM CDT, Gedare Bloom <ged...@rtems.org> wrote: >>>> Premysl, >>>> >>>> It looks good. I just have two requests for you to do: >>>> 1) Post the warnings you get when you compile. >>> Fixing them without papering over them is preferred but we can help if you >>> get stumped. >>> >>>> 2) Run the script >>>> http://git.rtems.org/rtems-testing/tree/merge-helpers/check_submission >>> >from within libbsp/arm/tms570 and post the results. >>> >>> Some of these may be false positives or hints for a human decision. Ask if >>> in doubt. >>> >>> >>>> Thanks, >>>> Gedare >>>> _______________________________________________ >>>> devel mailing list >>>> devel@rtems.org >>>> http://lists.rtems.org/mailman/listinfo/devel -- Joel Sherrill, Ph.D. Director of Research & Development joel.sherr...@oarcorp.com On-Line Applications Research Ask me about RTEMS: a free RTOS Huntsville AL 35805 Support Available (256) 722-9985 _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel