I am sorry for not attaching the patch and configuration command:
../rtems/configure --target=sparc-rtems4.11 --enable-rtemsbsp=sis
--enable-tests --disable-posix ENABLE_STRICT_ORDER_MUTEX=1
Thanks,
Saurabh Gadia
On Thu, Jun 4, 2015 at 6:08 PM, Saurabh Gadia <ga...@usc.edu> wrote:
> Hi,
> I worked out that bug related to strict_mutex and gone past that bug. But
> now I have issue while compiling the libtests. Below is the error log:
>
> '''
> sparc-rtems4.11-size syscall01.exe
> text data bss dec hex filename
> 266128 6064 11456 283648 45400 syscall01.exe
> cp syscall01.exe syscall01.ralf
> make[6]: Leaving directory
> `/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/testsuites/libtests/syscall01'
> Making all in dl01
> make[6]: Entering directory
> `/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/testsuites/libtests/dl01'
> sparc-rtems4.11-gcc -B../../../../../sis/lib/ -specs bsp_specs -qrtems
> -DHAVE_CONFIG_H -I.
> -I../../../../../../../rtems/c/src/../../testsuites/libtests/dl01 -I..
> -I../../../../../../../rtems/c/src/../../testsuites/libtests/../support/include
> -mcpu=cypress -O2 -g -ffunction-sections -fdata-sections -Wall
> -Wmissing-prototypes -Wimplicit-function-declaration -Wstrict-prototypes
> -Wnested-externs -MT dl-o1.o -MD -MP -MF .deps/dl-o1.Tpo -c -o dl-o1.o
> ../../../../../../../rtems/c/src/../../testsuites/libtests/dl01/dl-o1.c
> mv -f .deps/dl-o1.Tpo .deps/dl-o1.Po
> w -f dl.tar dl-o1.o
> 17:44:17 up 2:31, 2 users, load average: 2.27, 0.99, 0.53
> USER TTY LOGIN@ IDLE JCPU PCPU WHAT
> ../../../../../../tools/build/rtems-bin2c -C dl.tar dl-tar.c
> cannot open dl.tar for reading
> make[6]: *** [dl-tar.c] Error 1
> make[6]: Leaving directory
> `/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/testsuites/libtests/dl01'
> make[5]: *** [all-local] Error 1
> make[5]: Leaving directory
> `/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/testsuites/libtests'
> make[4]: *** [all] Error 2
> make[4]: Leaving directory
> `/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/testsuites/libtests'
> make[3]: *** [all-recursive] Error 1
> make[3]: Leaving directory
> `/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/testsuites'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory
> `/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory
> `/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c'
> make: *** [all-recursive] Error 1
> saurabh@saurabh-Inspiron-N5010:~/dev1/kernel/b-sis$ ls
> '''
>
> I am not able to find dl-tar.c but we have dl-tar.Po. Can anyone guide me
> on this. How should I proceed with this.
>
> Thanks,
>
> Saurabh Gadia
>
> On Mon, Jun 1, 2015 at 7:48 AM, Saurabh Gadia <ga...@usc.edu> wrote:
>
>> I am on it.
>>
>>
>> On Monday, June 1, 2015, Gedare Bloom <ged...@rtems.org> wrote:
>>
>>> Hi Saurabh,
>>>
>>> Please try to figure out how to fix the compile-error. You can see
>>> that the problem occurs in the #ifdef'd STRICT_ORDER_MUTEX_CODE, so
>>> that makes sense why others have not observed the same issue. It
>>> appears you will have to reconcile the new _Thread_Change_priority
>>> arguments with what is being used in that block of code. If you need
>>> more guidance please ask.
>>>
>>> Gedare
>>>
>>> On Mon, Jun 1, 2015 at 12:35 AM, Saurabh Gadia <ga...@usc.edu> wrote:
>>> > I wanted to test the ENABLE_STRICT_ORDER_MUTEX=1 related sptests for
>>> "nested
>>> > mutex" GSOC project. So please let me know what can be done.
>>> >
>>> > Thanks,
>>> >
>>> > Saurabh Gadia
>>> >
>>> > On Sun, May 31, 2015 at 9:33 PM, Saurabh Gadia <ga...@usc.edu> wrote:
>>> >>
>>> >> Hi,
>>> >> so I am working for sparc-sis setting and master branch. And if you
>>> see
>>> >> the code in threadimpl.h and threadchangepriority.c and
>>> coremutexsurrender.c
>>> >> the definition of _Thread_Change_priority() is having mismatch
>>> calling. Git
>>> >> records says that there was change to above function structure done by
>>> >> sebastian huber. But I guess he forgot to change the definition of
>>> >> _Thread_Change_priority() in threadimpl.h and call in
>>> coremutexsurrender.c
>>> >>
>>> >> Configuration command:
>>> >> ./configure --target=sparc-rtems4.11 --enable-rtemsbsp=sis
>>> --enable-tests
>>> >> --disable-posix ENABLE_STRICT_ORDER_MUTEX=1
>>> >>
>>> >> Error Log:
>>> >>
>>> >>
>>> ^
>>> >> In file included from
>>> >>
>>> ../../cpukit/../../../sis/lib/include/rtems/score/coremuteximpl.h:24:0,
>>> >> from
>>> >>
>>> ../../../../../../rtems/c/src/../../cpukit/score/src/coremutexsurrender.c:23:
>>> >> ../../cpukit/../../../sis/lib/include/rtems/score/threadimpl.h:394:6:
>>> >> note: expected 'void *' but argument is of type 'int'
>>> >> void _Thread_Change_priority(
>>> >> ^
>>> >>
>>> >>
>>> ../../../../../../rtems/c/src/../../cpukit/score/src/coremutexsurrender.c:60:7:
>>> >> error: too few arguments to function '_Thread_Change_priority'
>>> >> _Thread_Change_priority( holder, mutex->queue.priority_before,
>>> true
>>> >> );
>>> >> ^
>>> >> In file included from
>>> >>
>>> ../../cpukit/../../../sis/lib/include/rtems/score/coremuteximpl.h:24:0,
>>> >> from
>>> >>
>>> ../../../../../../rtems/c/src/../../cpukit/score/src/coremutexsurrender.c:23:
>>> >> ../../cpukit/../../../sis/lib/include/rtems/score/threadimpl.h:394:6:
>>> >> note: declared here
>>> >> void _Thread_Change_priority(
>>> >> ^
>>> >> make[6]: *** [src/libscore_a-coremutexsurrender.o] Error 1
>>> >>
>>> >> Thanks,
>>> >>
>>> >> Saurabh Gadia
>>> >>
>>> >> On Sun, May 31, 2015 at 8:25 PM, Nick Withers <
>>> nick.with...@anu.edu.au>
>>> >> wrote:
>>> >>>
>>> >>> Does re-running bootstrap in the source dir and re-configuring sort
>>> it?
>>> >>> --
>>> >>> Nick Withers
>>> >>>
>>> >>> Embedded Systems Programmer
>>> >>> Department of Nuclear Physics, Research School of Physics and
>>> Engineering
>>> >>> The Australian National University (CRICOS: 00120C)
>>> >>>
>>> >>> On Sun, 2015-05-31 at 20:31 -0400, Joel Sherrill wrote:
>>> >>> > More information is needed. Target architecture, bsp, configure
>>> >>> > command.
>>> >>> >
>>> >>> > I have been building all bsps regularly and unless it got broken
>>> this
>>> >>> > weekend, something else is up
>>> >>> >
>>> >>> >
>>> >>> > On May 31, 2015 7:57:04 PM EDT, Saurabh Gadia <ga...@usc.edu>
>>> wrote:
>>> >>> > >The problem is on master branch
>>> >>> > >
>>> >>> > >
>>> >>> > >Thanks,
>>> >>> > >
>>> >>> > >
>>> >>> > >Saurabh Gadia
>>> >>> > >
>>> >>> > >
>>> >>> > >On Sun, May 31, 2015 at 4:44 PM, Saurabh Gadia <ga...@usc.edu>
>>> wrote:
>>> >>> > >
>>> >>> > >Logs:
>>> >>> > >
>>> >>> > >make[6]: Entering directory
>>> >>> >
>>> >`/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/cpukit/score'
>>> >>> > >make[6]: *** No rule to make target `src/apimutexislocked.c',
>>> needed
>>> >>> > > by
>>> >>> > >`src/libscore_a-apimutexislocked.o'. Stop.
>>> >>> > >make[6]: Leaving directory
>>> >>> >
>>> >`/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/cpukit/score'
>>> >>> > >make[5]: *** [all-recursive] Error 1
>>> >>> > >
>>> >>> >
>>> >>> > >
>>> >...............................................................................................................
>>> >>> > >
>>> >>> > >There is no makefile but I am also not able to find
>>> apimutexislocked.c
>>> >>> > >
>>> >>> > >How do I proceed about this.
>>> >>> > >
>>> >>> > >
>>> >>> > >
>>> >>> > >Thanks,
>>> >>> > >
>>> >>> > >
>>> >>> > >Saurabh Gadia
>>> >>> >
>>> >>> > --joel
>>> >>> > _______________________________________________
>>> >>> > devel mailing list
>>> >>> > devel@rtems.org
>>> >>> > http://lists.rtems.org/mailman/listinfo/devel
>>> >>>
>>> >>>
>>> >>
>>> >
>>> >
>>> > _______________________________________________
>>> > devel mailing list
>>> > devel@rtems.org
>>> > http://lists.rtems.org/mailman/listinfo/devel
>>>
>>
>>
>> --
>> Thanks,
>>
>> Saurabh Gadia
>>
>>
>
diff --git a/cpukit/score/src/coremutexsurrender.c b/cpukit/score/src/coremutexsurrender.c
index d5dde1e..522bab6 100644
--- a/cpukit/score/src/coremutexsurrender.c
+++ b/cpukit/score/src/coremutexsurrender.c
@@ -57,7 +57,7 @@
_Chain_Get_first_unprotected( &holder->lock_mutex );
if ( mutex->queue.priority_before != holder->current_priority )
- _Thread_Change_priority( holder, mutex->queue.priority_before, true );
+ _Thread_Restore_priority( holder );
return CORE_MUTEX_STATUS_SUCCESSFUL;
}
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
