Hi all, I've almost prepared the basic layout for the GUI. Also added some dummy event handlers for File Menu.
Any more suggestions before fetching the options? Code at : https://github.com/anandkp92/waf/tree/waf/gui Thanks, Anand On Tue, Jun 16, 2015 at 10:45 AM, Anand Krishnan <anandk...@gmail.com> wrote: > Thomas: Apologies. This is the right link: > https://github.com/anandkp92/waf/blob/waf/gui/menu.py > > Thanks for the other input. I'll take care of in-code documentation and > making the code modular. > > I'll work on the tabs next. > > Regards, > Anand > > > On Tue, Jun 16, 2015 at 4:37 AM, Gedare Bloom <ged...@gwu.edu> wrote: > >> I just had one comment from reading the code, it lacks any code-level >> documentation. Granted it is simple now, but as it grows so should the >> doc. >> >> Also, make sure to watch out for when to break out into more >> functions/modules. Avoid the pitfall of "one block of code to rule >> them all" >> >> -Gedare >> >> On Mon, Jun 15, 2015 at 6:49 PM, Amar Takhar <a...@rtems.org> wrote: >> > On 2015-06-15 23:52 +0530, Anand Krishnan wrote: >> >> Hi all, >> >> >> >> Currently I have uploaded the first part of the gui - just plain menus >> (with no >> >> event handlers yet) to my github: github.com/anandkp92/waf/gui/menu.py >> . The >> >> purpose of the GUI is for creating the config.cfg file for "waf >> config" of the >> >> waf version of RTEMS. >> > >> > Looks good so far. >> > >> > >> >> I think you might need wxpython also to view it right now: http:// >> >> www.pygopar.com/installing-wxpython-3-on-ubuntu14-04/ >> > >> > Everyone here will be able to sort that out, thanks for the help. :) >> > >> > >> >> The main thing I want to get reviewed on is the code. I am planning to >> have >> >> different classes for menus, tabs, groups etc and a main class that >> creates >> >> multiple instances of each and puts it all together. >> > >> > It seems like a good start. >> > >> > >> >> Correct me if I am wrong: >> >> For the File options-> >> >> 1) New -> Opens a new instance with all the configuration options set >> to >> >> default again. >> > >> > Yes. >> > >> > >> >> 2) Save -> Save the configuration options chosen so far. >> > >> > Yes. >> > >> > >> >> 3) Open -> Open a previously saved set of configuration options. >> > >> > Yep. >> > >> > >> >> Once this is cleared, I shall move on to implementing these. >> > >> > OK. >> > >> > >> >> Please keep in mind this is a very crude version and the first part of >> many >> >> parts. >> > >> > Right. Lay out the panes and other UI Details before getting on to >> actual >> > options. I will help you with that. >> > >> > You will also need to decide how each option should be displayed. >> > >> > >> > Amar. >> > >> > _______________________________________________ >> > devel mailing list >> > devel@rtems.org >> > http://lists.rtems.org/mailman/listinfo/devel >> > >
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
