On 31 May 2018 at 00:28, Joel Sherrill <j...@rtems.org> wrote: > > > I may not understand correctly but there is test_run and coverage_run. > Someone > suggested making coverage_running an option to test_run. If that's what's > being > asked for, then I think doing it in a follow up patch is OK. > > If that's the intended request, perhaps a ticket should be filed. > > Sorry for all the confusion. This patch doesn't change the way test works. It only adds an option to run the coverage script. coverage_run just runs the coverage.coverage_run
> > >>>>> > except error.general as gerr: >>>>> > print(gerr) >>>>> > diff --git a/tester/rtems/testing/bsps/leon3-qemu-cov.ini >>>>> b/tester/rtems/testing/bsps/leon3-qemu-cov.ini >>>>> > index 6b5e7e6..2f89117 100644 >>>>> > --- a/tester/rtems/testing/bsps/leon3-qemu-cov.ini >>>>> > +++ b/tester/rtems/testing/bsps/leon3-qemu-cov.ini >>>>> > @@ -31,9 +31,10 @@ >>>>> > # >>>>> > # The Leon 3 QEMU BSP >>>>> > # >>>>> > -[leon3-qemu] >>>>> > +[leon3-qemu-cov] >>>>> > bsp = leon3-qemu >>>>> > arch = sparc >>>>> > +target = sparc-rtems5 >>>>> > tester = %{_rtscripts}/qemu.cfg >>>>> > bsp_qemu_opts = %{qemu_opts_base} -M leon3_generic >>>>> > bsp_qemu_cov_opts = -exec-trace %{test_executable}.cov >>>>> > diff --git a/tester/rtems/testing/coverage/symbol-sets.ini >>>>> b/tester/rtems/testing/coverage/symbol-sets.ini >>>>> > new file mode 100644 >>>>> > index 0000000..a2ec7bc >>>>> > --- /dev/null >>>>> > +++ b/tester/rtems/testing/coverage/symbol-sets.ini >>>>> > @@ -0,0 +1,36 @@ >>>>> > +# >>>>> > +# RTEMS Tools Project (http://www.rtems.org/) >>>>> > +# Copyright 2018 Chris Johns (chr...@rtems.org) >>>>> > +# All rights reserved. >>>>> > +# >>>>> > +# This file is part of the RTEMS Tools package in 'rtems-tools'. >>>>> > +# >>>>> > +# Redistribution and use in source and binary forms, with or without >>>>> > +# modification, are permitted provided that the following >>>>> conditions are met: >>>>> > +# >>>>> > +# 1. Redistributions of source code must retain the above copyright >>>>> notice, >>>>> > +# this list of conditions and the following disclaimer. >>>>> > +# >>>>> > +# 2. Redistributions in binary form must reproduce the above >>>>> copyright notice, >>>>> > +# this list of conditions and the following disclaimer in the >>>>> documentation >>>>> > +# and/or other materials provided with the distribution. >>>>> > +# >>>>> > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND >>>>> CONTRIBUTORS "AS IS" >>>>> > +# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED >>>>> TO, THE >>>>> > +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A >>>>> PARTICULAR PURPOSE >>>>> > +# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR >>>>> CONTRIBUTORS BE >>>>> > +# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, >>>>> OR >>>>> > +# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT >>>>> OF >>>>> > +# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR >>>>> BUSINESS >>>>> > +# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, >>>>> WHETHER IN >>>>> > +# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR >>>>> OTHERWISE) >>>>> > +# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF >>>>> ADVISED OF THE >>>>> > +# POSSIBILITY OF SUCH DAMAGE. >>>>> > +# >>>>> > + >>>>> > +[symbol-sets] >>>>> > +sets = score,rtems >>>>> > + >>>>> > +[libraries] >>>>> > +score = @BUILD-TARGET@/c/@BSP@/cpukit/score/libscore.a >>>>> > +rtems = @BUILD-TARGET@/c/@BSP@/cpukit/rtems/librtems.a >>>>> > diff --git a/tester/rtems/testing/qemu.cfg b/tester/rtems/testing/ >>>>> qemu.cfg >>>>> > index bfcd2f5..52a3752 100644 >>>>> > --- a/tester/rtems/testing/qemu.cfg >>>>> > +++ b/tester/rtems/testing/qemu.cfg >>>>> > @@ -51,8 +51,8 @@ >>>>> > # >>>>> > # Qemu common option patterns. >>>>> > # >>>>> > -#%define qemu_opts_base -no-reboot -monitor none -serial stdio >>>>> -nographic >>>>> > -%define qemu_opts_base -no-reboot -serial null -serial mon:stdio >>>>> -nographic >>>>> > +%define qemu_opts_base -no-reboot -monitor none -serial stdio >>>>> -nographic >>>>> > +#%define qemu_opts_base -no-reboot -serial null -serial mon:stdio >>>>> -nographic >>>>> >>>>> Why changing the common options for qemu? >>>>> >>>>> actually it's a bit experimental on advice of Cillian. >>>> It stayed in the patch. >>>> >>> >>> I know the impact of some of those options but maybe it would make sense >>> to add a comment block with the impact of each option? It would help >>> future >>> readers. >>> >>> And, from personal experience, qemu changes arguments from time to time. >>> Knowing >>> what the old intent was helps mapping to different versions and target >>> architectures. >>> >>> That's a good Idea. >> >>> >>> >>> >>>> > %define qemu_opts_no_net -net none >>>>> > >>>>> > # >>>>> > -- >>>>> > 2.14.3 >>>>> > >>>>> > _______________________________________________ >>>>> > devel mailing list >>>>> > devel@rtems.org >>>>> > http://lists.rtems.org/mailman/listinfo/devel >>>>> >>>> >>>> >>>> _______________________________________________ >>>> devel mailing list >>>> devel@rtems.org >>>> http://lists.rtems.org/mailman/listinfo/devel >>>> >>> >>> >> >
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel