On 16/9/20 12:48 am, Joel Sherrill wrote: > On Mon, Sep 14, 2020 at 9:33 PM <chr...@rtems.org <mailto:chr...@rtems.org>> > wrote: > > From: Chris Johns <chr...@rtems.org <mailto:chr...@rtems.org>> > > - Provide support for separate user and kernel include paths in > libbsd.py. > > - Update all added files with a suitable context to build them > with. Supported contexts are `kernel` and `user`. > > - Kernel source use the kernel, CPU, and build header paths in > this order. > > - User source use the user, kernel, CPU and build header paths > in this order. The FreeBSD /usr/include tree has some kernel > header files installed as well as user land header files. This > complicates the separation as some kernel header files are not > visible to user land code while other are. This is handled by > appeanding the kernel header paths to the user header paths so > > > ^^^ appending
Thanks. > Otherwise, I am just asking does Python code need to pass. pylint > and yapf are mentioned in this thread but > https://books.agiliq.com/projects/essential-python-tools/en/latest/linters.html > has a list of tools and claims that pycodelint matches pep8. I thought we > were trying to follow pep8. I thought yapf did pep8. I followed the 6.5.2 guide lines. > It also mentions pyflake which sounds useful. > > What is the recommended set of tools to pass and with what settings? > > I know we aren't completely passing on all Python code but what's the > objective from a tool checking viewpoint. This is existing code and I did not think we needed to pass pylint and yapf to make changes. I did pass the code through yapf as a separate patch to help the process. See 1/4. Pylint is more work than I have time avalable to do on this code. Chris _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
