-----Original Message----- From: Sebastian Huber <sebastian.hu...@embedded-brains.de> Sent: Monday, November 16, 2020 07:35 To: Kinsey Moore <kinsey.mo...@oarcorp.com>; devel@rtems.org Subject: Re: [PATCH 2/2] spec/aarch64: Only apply SUBALIGN(4) to ILP32
>On 16/11/2020 14:15, Kinsey Moore wrote: > >> The SUBALIGN(4) required on rtemsroset and rtemsrwset for ILP32 builds >> was previously present on LP64 builds and causes no issues within >> RTEMS, but causes relocation/alignment issues when building libbsd. >> This restricts those alignment changes to ILP32 builds. > > Please check it in if you think it is necessary. > > What troubles me a bit is that these SUBALIGN() stuff is present at all. > > It also troubles me that the splinkersets01 test case didn't catch this > problem. That test was what originally caught the problem during development of the A53 BSP. This patch isn't the addition of a fix for the alignment problems, it's an adjustment of the original fix to be compatible with libbsd's use of rtemsroset/rtemsrwset linker sections. Kinsey _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
