On 4/12/20 3:42 am, Gedare Bloom wrote: > On Thu, Dec 3, 2020 at 8:32 AM Sebastian Huber > <sebastian.hu...@embedded-brains.de > <mailto:sebastian.hu...@embedded-brains.de>> > wrote: > On 03/12/2020 16:25, Kinsey Moore wrote: > > The zynq-uart set_attributes implementation was configured to always > > return false which causes spconsole01 to fail. This restores the > > disabled implementation which sets the baud rate registers > > appropriately and allows spconsole01 to pass. This also expands the > > set_attributes functionality to allow setting of the stop bits, > > character width, and parity. > > The patch is fine from my point of view. > > The coding style is not in line with the RTEMS Project guidelines. > Should we even review patches with respect to the coding style? > > I don't keep it strict in the bsps/ area. > > Hopefully, we can make tools help us ;)
+1 Chris _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
