On Tue, Mar 23, 2021 at 9:57 AM Joel Sherrill <j...@rtems.org> wrote: > > > > On Tue, Mar 23, 2021 at 10:49 AM Sebastian Huber > <sebastian.hu...@embedded-brains.de> wrote: >> >> Hello Alex, >> >> this file has little in common with the RTEMS coding style. This is >> quite understandable since the style is very exotic. I don't think we >> will have a formatting tool which is able to produce the RTEMS style in >> the near future. This gives raise to some general questions. >> >> 1. Do we care about the coding style? > > > Yes. >> >> >> 2. Who wants to enforce the coding style? > > > I hope we all catch these when we spot them. > > Alex will reformat it. > >> >> >> 3. Should new files use a new style understood by a well known tool and >> a well known coding style? > > > That would be preferable but like the license change and SPDX markers, this > is down the list. > > You have something that is close. If you want to add it to rtems-tools as a > starting > point that is accessible, we can start to use it and see how it goes. > >> >> >> I see a lot of >> >> type var = initial_value; >> >> Maybe we should drop the stone age variable declarations at block begin >> if we choose a new style and declare and initialize local variables upon >> first use. > > > I don't know when this was started but it was never part of the original > RTEMS style. > > Personally I have never liked it. >
It is a holdover from K&R and the gcc -ansi flag would complain if you didn't do it. (For older compiler writers, it made it a lot easier to parse and generate the code if you could pass over all the stack allocations in one group.) > --joel > >> >> >> -- >> embedded brains GmbH >> Herr Sebastian HUBER >> Dornierstr. 4 >> 82178 Puchheim >> Germany >> email: sebastian.hu...@embedded-brains.de >> phone: +49-89-18 94 741 - 16 >> fax: +49-89-18 94 741 - 08 >> >> Registergericht: Amtsgericht München >> Registernummer: HRB 157899 >> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler >> Unsere Datenschutzerklärung finden Sie hier: >> https://embedded-brains.de/datenschutzerklaerung/ >> >> _______________________________________________ >> devel mailing list >> devel@rtems.org >> http://lists.rtems.org/mailman/listinfo/devel > > _______________________________________________ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel