I'm not confident about assessing the libbsd patches. Hopefully someone else may comment, but not too many experts in that area yet :)
I guess the one thing that concerned me is filling the media with a pattern. I suppose one should know what the test does, and that it will destroy all data on the disk. Maybe that is already documented/expected, but it should be clear. On Thu, Mar 25, 2021 at 2:35 AM Christian Mauderer <christian.maude...@embedded-brains.de> wrote: > > Hello, > > the patch set for RTEMS, libbsd and docs add a SDMMC driver for STM32H7 > to libbsd. Note that I added the md5 command to media01 which is useful > when testing storage devices. Beneath that I added a command that can > fill a disk or a file with an incrementing number which - again - can be > useful for testing storage media. The later command is only added to > media01 because I don't think it's a useful general purpose command but > rather a pure test command. > > Patches belonging to this set: > > RTEMS: > [PATCH rtems 1/2] stm32h7: Add SDMMC modules to clock. > [PATCH rtems 2/2] stm32h7: Add init for sdmmc pins. > > libbsd: > [PATCH rtems-libbsd 1/3] testsuite/media01: Enable md5 command > [PATCH rtems-libbsd 2/3] testsuite/media01: Add pattern test. > [PATCH rtems-libbsd 3/3] STM32H7: Add SDMMC driver > > docs: > [PATCH rtems-docs] user/bsps: Add STM32H7 SDMMC driver > > Best regards > > Christian > > _______________________________________________ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel