Should I provide the changes for the code review as a separate patch or should I squash them again?
Using the upstream unchanged is tricky because the code was taken from the examples and these examples are always targeted towards a specific API. I changed the version to be usable by both APIs. I now applied the __rtems__ preprocessor defines where applicable and moved the preprocessor defines into a separate file. Kind Regards Robin On Tue, 27 Apr 2021 at 22:21, Gedare Bloom <ged...@rtems.org> wrote: > On Tue, Apr 27, 2021 at 2:09 PM Gedare Bloom <ged...@rtems.org> wrote: > > > > On Tue, Apr 27, 2021 at 11:41 AM Robin Mueller > > <robin.muelle...@gmail.com> wrote: > > > > > I'm not sure what happened, it looks like my email client garbled the > inline threaded reply. Hopefully my comments come through for you ok. >
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel