On 7/9/2022 4:41 am, Kinsey Moore wrote:
I'm not opposed to this change since it reduces repetition a bit, but was there a particular reason for it beyond that?
Yes there is. The arch/bsp checks ...
- if bld.env.RTEMS_ARCH_BSP.startswith('arm-rtems6-tms570ls3137_hdk'):
... included the major version of RTEMS which breaks once we move to 7, 8 ....
And I have left `RTEMS_ARCH_BSP` in the environment but it is really an internal working variable of rtems_waf.
- drv_incl.append('uLan/ports/driver/tms570_emac') - drv_incl.append('uLan/ports/os')- driver_source.extend(walk_sources('uLan/ports/driver/tms570_emac'))+ if arch == 'arm': + # These files will not compile for BSPs other than TMS570 + if bsp.startswith('tms570ls3137_hdk'):
Duc, please make the check exact. A BSP name should be a one to match and if you have to match more than one I suggest you use:
if bsp in ['tms570ls3137_hdk', 'tms570ls3137_hdk.extra']: Chris _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
