On Tue, Mar 21, 2023, 9:32 PM Chris Johns <chr...@rtems.org> wrote:

> On 22/3/2023 3:29 pm, Gedare Bloom wrote:
> > These patches look ok for rtems-net-legacy.
>
> Yes and again sorry for the wrong subject line.
>
> > In general, net-legacy is ok for maintenance patches. Any new features
> > will be heavily scrutinized and need additional discussions.
>
> Agreed. These are maintenance changes only and there is a ticket. I think
> this
> repo needs tickets for changes so these release notes contain any changes.
>

Is this easy to enforce with git rules?

>
> > Please run the python file through yapf consistent with
> > https://docs.rtems.org/branches/master/eng/python-devel.html
> > feel free to send the format fix separately. this should help reduce
> > whitespace changes in the future patches to net-legacy.
>
> Good idea. Hmmm there is a few changes so I will add this as a separate
> patch.
>
>
> Thanks for the prompt review. A v2 coming.
>
> Chris
> _______________________________________________
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to