Hi Maxim

I think this patch broke the build on linux:

In file included from rtpp_session.c:41:
rtpp_defines.h:120: error: expected specifier-qualifier-list before ‘uint8_t’
rtpp_session.c: In function ‘init_hash_table’:
rtpp_session.c:53: error: ‘struct cfg’ has no member named ‘rand_table’
rtpp_session.c: In function ‘hash_string’:
rtpp_session.c:62: error: ‘struct cfg’ has no member named ‘rand_table’
rtpp_session.c:63: error: ‘struct cfg’ has no member named ‘rand_table’
rtpp_session.c: In function ‘hash_table_append’:
rtpp_session.c:78: error: ‘struct cfg’ has no member named ‘hash_table’
rtpp_session.c:80: error: ‘struct cfg’ has no member named ‘hash_table’
rtpp_session.c: In function ‘hash_table_remove’:
rtpp_session.c:108: error: ‘struct cfg’ has no member named ‘hash_table’
rtpp_session.c:109: error: ‘struct cfg’ has no member named ‘hash_table’
rtpp_session.c: In function ‘session_findfirst’:
rtpp_session.c:122: error: ‘struct cfg’ has no member named ‘hash_table’
rtpp_session.c: In function ‘remove_session’:
rtpp_session.c:164: error: ‘struct cfg’ has no member named ‘log_level’
rtpp_session.c:167: error: ‘struct cfg’ has no member named ‘log_level’
rtpp_session.c:170: error: ‘struct cfg’ has no member named ‘log_level’
rtpp_session.c: In function ‘reconnect_timeout_handler’:
rtpp_session.c:285: error: ‘struct cfg’ has no member named ‘log_level’
rtpp_session.c:287: error: ‘struct cfg’ has no member named ‘log_level’
rtpp_session.c:292: error: ‘struct cfg’ has no member named ‘log_level’
rtpp_session.c:302: error: ‘struct cfg’ has no member named ‘log_level’
rtpp_session.c: In function ‘do_timeout_notification’:
rtpp_session.c:322: error: ‘struct cfg’ has no member named ‘log_level’
rtpp_session.c:342: error: ‘struct cfg’ has no member named ‘log_level’
make[1]: *** [rtpp_session.o] Error 1
make[1]: Leaving directory `/home/alfredh/cvs/rtpproxy'
make: *** [all] Error 2

(Build host is Debian Lenny, gcc v4.3.2)


one way to fix this, is to include config.h from rtpp_defines.h:


Index: rtpp_defines.h
===================================================================
RCS file: /cvsroot/ser/rtpproxy/rtpp_defines.h,v
retrieving revision 1.23
diff -u -3 -r1.23 rtpp_defines.h
--- rtpp_defines.h      24 Dec 2008 10:28:06 -0000      1.23
+++ rtpp_defines.h      12 Jan 2009 10:42:02 -0000
@@ -31,6 +31,8 @@
  #ifndef _RTPP_DEFINES_H_
  #define _RTPP_DEFINES_H_

+#include "config.h"
+
  #include <sys/types.h>
  #include <sys/time.h>
  #include <sys/resource.h>


this fixes the build error, and if this is a good solution, then I think
you should make sure that config.h is included in all .[hc] files.


Then, there is only one warning left:

$ make -s
rtpp_command.c: In function ‘handle_command’:
rtpp_command.c:510: warning: pointer targets in passing argument 1 of 
‘url_unquote’ differ in signedness


/alfred

Maxim Sobolev wrote:
> sobomax     2008/12/24 11:28:06 CET
> 
>   SER CVS Repository
> 
>   Modified files:
>     .                    rtpp_defines.h 
>   Log:
>   Use HAVE_STDINT_H instead of checking for particular operating system.
>   
>   Revision  Changes    Path
>   1.23      +2 -4      rtpproxy/rtpp_defines.h
> http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/rtpproxy/rtpp_defines.h.diff?r1=1.22&r2=1.23
> _______________________________________________
> Devel mailing list
> [email protected]
> http://lists.rtpproxy.org/mailman/listinfo/devel

_______________________________________________
Devel mailing list
[email protected]
http://lists.rtpproxy.org/mailman/listinfo/devel

Reply via email to