Hi Waldemar,

On Sun, Jul 10, 2016 at 9:25 AM, Waldemar Brodkorb <[email protected]> wrote:
> I want to add following cleanup patch.
> No regressions found.
>
> Okay? Comments?

The following looks either broken or unused in the current code,
given there's no matching PTR_MANGLE:

diff --git a/libc/sysdeps/linux/x86_64/sched_getcpu.S
b/libc/sysdeps/linux/x86_64/sched_getcpu.S
index f8c09c0..1e0a344 100644
--- a/libc/sysdeps/linux/x86_64/sched_getcpu.S
+++ b/libc/sysdeps/linux/x86_64/sched_getcpu.S
@@ -37,7 +37,6 @@ ENTRY (sched_getcpu)

 #ifdef SHARED
     movq    __vdso_getcpu(%rip), %rax
-    PTR_DEMANGLE (%rax)
     callq    *%rax
 #else
 # ifdef __NR_getcpu


AFAICS PTR_MANGLE/PTR_DEMANGLE are still present in glibc, but their
use in common code is conditional, though in arch-specific code it is not.

Do you plan for syncing with glibc in the future?

-- 
Thanks.
-- Max
_______________________________________________
devel mailing list
[email protected]
http://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel

Reply via email to