Waldemar, Alexey, On Wed, Dec 7, 2016 at 6:48 PM, Waldemar Brodkorb <w...@uclibc-ng.org> wrote: > following patch was developed by crosstool-ng developer. > Okay to commit?
I've got a couple questions: > diff --git a/libpthread/nptl/sysdeps/Makefile.commonarch > b/libpthread/nptl/sysdeps/Makefile.commonarch > index c206ac9..134eade 100644 > --- a/libpthread/nptl/sysdeps/Makefile.commonarch > +++ b/libpthread/nptl/sysdeps/Makefile.commonarch > @@ -32,10 +32,11 @@ libpthread_arch_SOBJ = $(patsubst > %.S,$(libpthread_arch_OUT)/%.o,$(libpthread_ar > libpthread_arch_OBJS = $(libpthread_subarch_OBJS) $(libpthread_arch_COBJ) > $(libpthread_arch_SOBJ) > > libc_arch_COBJ = $(patsubst %.c,$(libpthread_arch_OUT)/%.o,$(libc_arch_CSRC)) > -libc_arch_SOBJ = $(patsubst %.c,$(libpthread_arch_OUT)/%.o,$(libc_arch_SSRC)) > +libc_arch_SOBJ = $(patsubst %.S,$(libpthread_arch_OUT)/%.o,$(libc_arch_SSRC)) I see that there's a copy-paste-type error, but this change is not a part of this fix, right? > diff --git a/libpthread/nptl/sysdeps/xtensa/Makefile.arch > b/libpthread/nptl/sysdeps/xtensa/Makefile.arch > index 9e63b19..c26e197 100644 > --- a/libpthread/nptl/sysdeps/xtensa/Makefile.arch > +++ b/libpthread/nptl/sysdeps/xtensa/Makefile.arch > @@ -15,12 +15,11 @@ > # License along with the GNU C Library; see the file COPYING.LIB. If > # not, see <http://www.gnu.org/licenses/>. > > -ASFLAGS-dl-tlsdesc.S = -DNOT_IN_libc=1 Why is it removed? It changes the way dl-tlsdesc.S is built for the ld.so, not for the libc. I'm not sure why it was needed at all if it builds identically both with and without it, but it's also not a part of this fix, right? -- Thanks. -- Max _______________________________________________ devel mailing list devel@uclibc-ng.org http://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
