Rootless code in Xserver/miext/rootless has a small bug.
Kensuke Matsuzaki
diff -u -r1.6 rootlessWindow.c --- rootlessWindow.c 23 Jul 2003 00:48:58 -0000 1.6 +++ rootlessWindow.c 24 Oct 2003 13:02:02 -0000 @@ -889,9 +889,9 @@ gResizeDeathBits = xalloc(copy_rowbytes * copy_rect_height);
- if (rootless_CopyWindow_threshold && + if (rootless_CopyBytes_threshold && copy_rect_width * copy_rect_height > - rootless_CopyWindow_threshold) + rootless_CopyBytes_threshold) { SCREENREC(pScreen)->imp->CopyBytes( copy_rect_width * Bpp, copy_rect_height,
Thanks for catching that. I'll apply your patch.
A side note about the rootless acceleration functions: In the top of the tree (since yesterday) we have added lots more use of these optional functions. They are also tested for existence directly instead of using the corresponding threshold. For example we would test here for SCREENREC(pScreen)->imp->CopyBytes to not be NULL instead of rootless_CopyBytes_threshold != 0. This seems safer and is no slower if the test is true. Please let me know if you have any comments or questions.
--Torrey _______________________________________________ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
