On Tue, Jan 27, 2004 at 01:07:00PM -0500, David Dawes wrote:
> Does anyone have a reason to not apply the patch attached to
> <http://bugs.xfree86.org/show_bug.cgi?id=935>?

I don't think this patch is correct.  What it does is enable the CRTC
while writing the new mode -- generally that is bad.  I would suggest
either (1) removing the "R128_CRTC_VSYNC_DIS | R128_CRTC_HSYNC_DIS" from
the R128RestoreCrtcRegisters code or (2) add those bits to the
R128Unblank code.  #1 will change the behavior from putting the monitor
in suspend mode during the CRTC changes to just blanking the screen,
while #2 will automatically enable the H&V sync signals when the screen
is unblanked after a mode switch.  Both should be safe.

Are there others that have R128 laptops who could test this solution to
see if it works for them?  I no longer have a R128 laptop.

Kevin
_______________________________________________
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel

Reply via email to