Revision: 1212
Author: [email protected]
Date: Mon May 3 14:44:45 2010
Log: Only use perl -f when it's valid.
Tweak HACKING.
http://code.google.com/p/perl-devel-nytprof/source/detail?r=1212
Modified:
/trunk/Changes
/trunk/HACKING
/trunk/lib/Devel/NYTProf/Run.pm
/trunk/t/42-global.t
/trunk/t/lib/NYTProfTest.pm
=======================================
--- /trunk/Changes Mon May 3 13:49:06 2010
+++ /trunk/Changes Mon May 3 14:44:45 2010
@@ -16,8 +16,8 @@
=head2 Changes in Devel::NYTProf 3.12 (svn 1194) 22nd April 2010
XXX TODO
-Refine and document handing of string evals
Consider eval_pv from outside perl, e.g. plperl
+On eval report add links to sibling eval reports
Major changes:
=======================================
--- /trunk/HACKING Mon May 3 14:06:40 2010
+++ /trunk/HACKING Mon May 3 14:44:45 2010
@@ -302,9 +302,6 @@
Investigate style.css problem when using --outfile=some/other/dir
-Index should show eval fids in some form - collapsed per location?
-Or just included in the stats for the outer source file.
-
Sub profiler should avoid sv_setpvf(subname_sv, "%s::%s", stash_name,
GvNAME(gv));
because it's expensive (Perl_sv_setpvf_nocontext accounts for 29% of
pp_entersub_profiler).
Use a two level hash: HvNAME(GvSTASH(gv)) then GvNAME(gv).
@@ -391,7 +388,6 @@
Would enable a dprofpp -T like output. See
https://rt.cpan.org/Ticket/Display.html?id=50766
For eval fid reports:
-- Add header with link to location of the invoking string eval
- Add links to 'sibling' evals
- Add eval information (evals and time) to file summary header
=======================================
--- /trunk/lib/Devel/NYTProf/Run.pm Thu Mar 11 03:02:29 2010
+++ /trunk/lib/Devel/NYTProf/Run.pm Mon May 3 14:44:45 2010
@@ -53,7 +53,7 @@
my @perl = ($this_perl, '-d:NYTProf');
# (sadly, testing $Config{usesitecustomize} isn't reliable)
- if ($Config{ccflags} =~ /(?<!\w)-DUSE_SITECUSTOMIZE\b/) {
+ if ($Config{usesitecustomize} eq 'define' or $Config{ccflags} =~
/(?<!\w)-DUSE_SITECUSTOMIZE\b/) {
push @perl, '-f' if $opt{skip_sitecustomize};
}
=======================================
--- /trunk/t/lib/NYTProfTest.pm Mon May 3 13:49:06 2010
+++ /trunk/t/lib/NYTProfTest.pm Mon May 3 14:44:45 2010
@@ -352,7 +352,10 @@
sub run_perl_command {
my ($cmd, $show_stdout) = @_;
local $ENV{PERL5LIB} = $perl5lib;
- run_command("$this_perl -f $cmd", $show_stdout);
+ my @opts;
+ push @opts, '-f' if $Config{usesitecustomize} eq 'define'
+ or $Config{ccflags} =~ /(?<!\w)-DUSE_SITECUSTOMIZE\b/;
+ run_command("$this_perl @opts $cmd", $show_stdout);
}
--
You've received this message because you are subscribed to
the Devel::NYTProf Development User group.
Group hosted at: http://groups.google.com/group/develnytprof-dev
Project hosted at: http://perl-devel-nytprof.googlecode.com
CPAN distribution: http://search.cpan.org/dist/Devel-NYTProf
To post, email: [email protected]
To unsubscribe, email: [email protected]
