Quoting Thorsten Haude <[EMAIL PROTECTED]>: > Hi, > > * Ivan Skytte Jørgensen wrote (2007-10-13 13:54): > >I gave the I also gave it a spin with Flexelint 8.0w.... > https://sourceforge.net/tracker/index.php?func=detail&aid=1860273&group_id=11005&atid=111005 > > Thank you for your help! ...
> >selection.c:95-110 > > char *endptr; > > ... > > if (isdigit((unsigned char) *endptr ) ... > >Why the cast? > > To clear things up? I changed it into (int). No! No! No! That unsigned char was there for a REASON! (I mentioned it in an earlier mail - just think "sign extension" for signed chars, and the range of valid character points in iso8859-1 (say); then that business about the unsafe implementation I mentioned.) And anyway casting a char to an int just adds noise; if you remove (unsigned char) casting, don't add (int) in its place: that's implicit. Tony -- NEdit Develop mailing list - [email protected] http://www.nedit.org/mailman/listinfo/develop
