Hi.

Analyzing one bug report on FreeBSD I've found that system reliably
panics on `zfs inherit iscsioptions pool/volume` and `zfs inherit
stmf_sbd_lu pool/volume`.  As far as I can see, those two cases are the
only string properties that have no default value, that causes kernel
panic on attempt to unset them, or in some cases (as in the bug report:
https://bugs.freenas.org/issues/17118) on receiving them in replication
stream.

Should those properties have some default values, or code setting
default should handle this situation explicitly as absence of default
value?  None of those properties are used on FreeBSD, so I am not sure
whether empty value is correct default there.

Also, is there reason to declare properties applicable only to
ZFS_TYPE_VOLUME as PROP_INHERIT, not as PROP_DEFAULT?  From where can
they inherit their values if volumes can not be nested?

-- 
Alexander Motin


-------------------------------------------
openzfs-developer
Archives: https://www.listbox.com/member/archive/274414/=now
RSS Feed: https://www.listbox.com/member/archive/rss/274414/28015062-cce53afa
Modify Your Subscription: 
https://www.listbox.com/member/?member_id=28015062&id_secret=28015062-f966d51c
Powered by Listbox: http://www.listbox.com

Reply via email to