I have provided my feedback and want reply to this thread :)
i’m using one copy of zfs tests on dilos and smartos based envs with different
replaces in tools locations.
example of zt.sh script:
DilOS:
root@dilos-zfs:/opt# cat zt.sh
#!/bin/bash
export SUDO=/usr/bin/sudo
export CHMOD=/system/bin/chmod
export CHOWN=/system/bin/chown
export CHGRP=/system/bin/chgrp
export CP=/system/bin/cp
export DF=/system/bin/df
export PAX=/system/bin/pax
export CPIO=/system/bin/cpio
#export DD=/system/bin/dd
export TAR=/system/bin/tar
export ECHO=/system/bin/echo
export SUM=/system/bin/sum
export FIND=/system/bin/find
export GREP=/system/bin/grep
export LS=/system/bin/ls
export COMPRESSION=/system/bin/compression
export UNCOMPRESSION=/system/bin/uncompression
#export FILE=/system/bin/file
export FILE="/usr/bin/file -L"
export PYTHON=/usr/bin/python2.7
ARGS="$*"
if [ "x$ARGS" = "x" ]; then
ARGS="-c /opt/dilos.run"
fi
#export DISKS="c1d1 c1d0 c0d1"
export DISKS="c4t0d0 c3t0d0 c2t0d0"
#export KEEP="rpool zones fakeroot"
export KEEP="rpool"
#export FAKEROOT="/fakeroot/tmp/tmp"
# need investigate
#export TEST_BASE_DIR="${FAKEROOT}/"
LOG=$(date +'%Y%m%d-%H%M')
#rm -rf ${FAKEROOT}/*
#time /opt/zfs-tests/bin/zfstest $ARGS 2>&1 | tee /var/tmp/${LOG}.zt.log.txt
time /opt/zfs-tests/bin/zfstest $ARGS
#time /opt/zfs-tests/bin/zfstest2 $ARGS
smartos based env:
[root@test-zfs /opt]# cat zt.sh
#!/bin/bash
export
PATH=/usr/bin:/usr/sbin:/smartdc/bin:/opt/smartdc/bin:/opt/local/bin:/opt/local/sbin:/opt/smartdc/agents/bin
export SUDO=/opt/local/bin/sudo
export PYTHON=/opt/local/bin/python2.7
export TRUNCATE=/opt/local/bin/truncate
export GNUDD=/opt/local/bin/gdd
export SHUF=/opt/local/bin/shuf
export MD5SUM=/opt/local/bin/md5sum
ARGS="$*"
if [ "x$ARGS" = "x" ]; then
ARGS="-c /opt/dilos.run"
fi
#export DISKS="c1d1 c1d0 c0d1"
export DISKS="c4t0d0 c3t0d0 c2t0d0"
#export DISKS="cad10101 cad10102 cad10103"
export KEEP="zones rpool"
#export FAKEROOT="/fakeroot/tmp/tmp"
LOG=$(date +'%Y%m%d-%H%M')
# fix from smartos based env
${SUDO} umount /etc/shadow
${SUDO} cp -f /usbkey/shadow /etc/shadow
${SUDO} umount /etc/passwd
${SUDO} cp -f /usbkey/passwd /etc/passwd
# fix dump and swap
DUMPDEV=$(${SUDO} dumpadm | grep "Dump device:" | nawk '{print $3}')
if [ "$DUMPDEV" = "none" ]; then
${SUDO} /usr/sbin/dumpadm -d /dev/zvol/dsk/zones/dump
fi
SWAPDEV=$(${SUDO} swap -l 2>&1)
if [ "$SWAPDEV" = "No swap devices configured" ]; then
${SUDO} /usr/sbin/swap -a /dev/zvol/dsk/zones/swap
fi
#COREADMDUMPS=$(${SUDO} coreadm | grep "global core dumps:" | sed -e
's/.*global core dumps: //')
#if [ "$COREADMDUMPS" = "enabled" ]; then
# ${SUDO} coreadm -d global
#fi
#
/opt/zfs-tests/bin/zfstest $ARGS 2>&1 | tee /var/tmp/${LOG}.zt.log.txt
as you can see - i can redefine some tools locations if needed on different
system and try to do symlonks will be overhead to me with my different env.
i’m not interested in current update, but as i said before - i can manage it on
my tree.
best regards,
-Igor
> On Sep 1, 2016, at 6:13 PM, Dan McDonald <[email protected]> wrote:
>
> Glanced over the $CMD -> cmd changes, and did not see anything objectionable.
> The path-constraining logic and the cleanups in the three specified files
> above also seem alright. There's a pre-existing packaging dependency
> condition I see thanks to these being reorganized (requirement of GNU
> utilties for gnu dd(1)), but that's not a blocker for THIS bug.
>
> Ship it.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/openzfs/openzfs/pull/174#issuecomment-244111268>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AOi0K6h8O5DOPzrVFjt1-v8dYh0tzOoYks5qluu2gaJpZM4JjQ0V>.
>
> openzfs-developer | Archives
> <https://www.listbox.com/member/archive/274414/=now>
> <https://www.listbox.com/member/archive/rss/274414/28059325-76ffcbac> |
> Modify <https://www.listbox.com/member/?&;> Your Subscription
> <http://www.listbox.com/>
-------------------------------------------
openzfs-developer
Archives: https://www.listbox.com/member/archive/274414/=now
RSS Feed: https://www.listbox.com/member/archive/rss/274414/28015062-cce53afa
Modify Your Subscription:
https://www.listbox.com/member/?member_id=28015062&id_secret=28015062-f966d51c
Powered by Listbox: http://www.listbox.com
