It's just really strange to me that this does anything, because in the logic 
above in `vdev_raidz_reconstruct_q` we're doing this:

                uint64_t size = (c == x) ? 0 : MIN(rm->rm_col[x].rc_size,
                    rm->rm_col[c].rc_size);

As a result I think the `size` we pass to `abd_copy` in that case is 0, which 
means that we'll never actually call `memcopy` (because in `abd_iterate_func2` 
the callback logic is wrapped with `while (size > 0)`).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/commit/4ee0199ec059ca9417a72125beae8d89fbc5a9df#commitcomment-21956560
------------------------------------------
openzfs-developer
Archives: https://openzfs.topicbox.com/groups/developer/
Powered by Topicbox: https://topicbox.com

Reply via email to