avg-I commented on this pull request.


> @@ -6882,10 +6882,10 @@ l2arc_write_buffers(spa_t *spa, l2arc_dev_t *dev, 
> uint64_t target_sz)
 
        ASSERT3U(write_asize, <=, target_sz);
        ARCSTAT_BUMP(arcstat_l2_writes_sent);
-       ARCSTAT_INCR(arcstat_l2_write_bytes, write_asize);
+       ARCSTAT_INCR(arcstat_l2_write_bytes, write_psize);
        ARCSTAT_INCR(arcstat_l2_size, write_sz);

George, this is a good suggestion, but I am concerned that this might cause 
some trouble for external tools that monitor ZFS ARC or convert its statistics 
for a nice presentation, etc.  arcstats.py comes to mind.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/310#discussion_r119853620
------------------------------------------
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/Td414270217188b5f-M4281ffee914bea087b0cae5c
Powered by Topicbox: https://topicbox.com

Reply via email to