grwilson commented on this pull request.
> @@ -209,12 +209,13 @@ enum zio_flag {
ZIO_FLAG_CANFAIL)
enum zio_child {
- ZIO_CHILD_VDEV = 0,
- ZIO_CHILD_GANG,
- ZIO_CHILD_DDT,
- ZIO_CHILD_LOGICAL,
- ZIO_CHILD_TYPES
+ ZIO_CHILD_VDEV = 1 << 0,
+ ZIO_CHILD_GANG = 1 << 1,
+ ZIO_CHILD_DDT = 1 << 2,
+ ZIO_CHILD_LOGICAL = 1 << 3
Yeah, I looked at this option but didn't like how it looked specifically for
this reason. I've looked at using variable arguments too but it has drawback
too. I'm going to consider this option again but using a variable to hold the
bits we plan to pass into `zio_wait_for_children`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/505#discussion_r158716835
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/Td0adf1bfacf39ae0-Ma54010b2908fc3d5b0c3ea0a
Powered by Topicbox: https://topicbox.com
