pcd1193182 commented on this pull request.


> @@ -424,16 +424,20 @@ zfs_iter_snapspec(zfs_handle_t *fs_zhp, const char 
> *spec_orig,
 
 /*
  * Iterate over all children, snapshots and filesystems
+ * Process snapshots before filesystems because they are nearer the input
+ * handle: this is extremely important when used with zfs_iter_f functions
+ * looking for data, following the logic that we would like to find it as soon
+ * and closer as possible.

One small nit: "as close as possible", rather than "closer"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/510#pullrequestreview-93380567
------------------------------------------
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T5c0e5494ef6a3edc-Mace6fcf4b04f2314380ccd5f
Powered by Topicbox: https://topicbox.com

Reply via email to