ahrens approved this pull request.
> @@ -2606,6 +2673,9 @@ receive_read_record(struct receive_arg *ra)
{
int err;
+ if ((err = receive_record_safe(ra)) != 0)
I prefer to not have side effects in the `if` when practical:
```
err = ...;
if (err != 0)
...
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/630#pullrequestreview-114873930
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/discussions/T24c73b28b49842ac-M1b1936a6c937999ca5d03032
Delivery options: https://openzfs.topicbox.com/groups
