ahrens commented on this pull request.
> (void) fprintf(stderr, "TIME SENT SNAPSHOT\n");
/*
* Print the progress from ZFS_IOC_SEND_PROGRESS every second.
*/
for (;;) {
- (void) sleep(1);
+
+ /*
+ * If we are doing 'send -v' sleep for 1 second, otherwise
+ * sleep forever, until signal or quitting.
+ */
+ if (!pa->pa_progress) {
+ while(send_progress_thread_signal == 0)
style: add space after `while`
> @@ -70,7 +70,8 @@ int lzc_get_holds(const char *, nvlist_t **);
enum lzc_send_flags {
LZC_SEND_FLAG_EMBED_DATA = 1 << 0,
LZC_SEND_FLAG_LARGE_BLOCK = 1 << 1,
- LZC_SEND_FLAG_COMPRESS = 1 << 2
+ LZC_SEND_FLAG_COMPRESS = 1 << 2,
+ LZC_SEND_FLAG_SIGINFO = 1 << 3
Given that there's no kernel or libzfs_core component to the SIGINFO stuff, I
don't think it makes sense for it to be a libzfs_core flag. Libzfs already
knows to do this based on the new member in sendflags_t, so I think you can
just remove `LZC_SEND_FLAG_SIGINFO` (and the handling of it, which is
effectively a no-op).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/638#pullrequestreview-118452847
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/discussions/T000e5d283b7db7e5-Mff1d73d11944b59b0e1135ea
Delivery options: https://openzfs.topicbox.com/groups
