waikontse commented on this pull request.
> @@ -392,6 +392,22 @@ static int
dump_freeobjects(dmu_sendarg_t *dsp, uint64_t firstobj, uint64_t numobjs)
{
struct drr_freeobjects *drrfo = &(dsp->dsa_drr->drr_u.drr_freeobjects);
+ uint64_t maxobj = DNODES_PER_BLOCK *
+ (DMU_META_DNODE(dsp->dsa_os)->dn_maxblkid + 1);
+
+ /*
+ * Older versions of OpenZFS (since 7104) does not handle large
+ * FREEOBJECTS records correctly, leading to zfs recv never
completing.
Hi @ahrens, thanks for the guidance on the commenting.
I need to get used to tab spaces, I usually use spaces.
You're right, what I mean is that versions "less recent"/"older than". I'll
update the formatting with the comment later today.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/685#discussion_r221905306
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/Tcf25f566d2c2fe2d-Meb3fb3a23b754da194914588
Delivery options: https://openzfs.topicbox.com/groups/developer/subscription
