Thanks @behlendorf. I think the potential issue with cv_destroy() is out of scope for this change, which isn't really touching that (just renaming the cv that it's operating on). I agree that if conflicting changes were made in ZoL, you'll want to keep the ZoL version and just change the names. IIRC @pcd1193182 did some research a while back on the issue of accidentally using a CV after destroying it, he may be able to comment on if the same problem is possible on illumos.
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/680#issuecomment-426450765 ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/T0ada5cf1c6037d04-Ma26240ffd4911388de562c5f Delivery options: https://openzfs.topicbox.com/groups/developer/subscription