hi! Any comments please?
rgds, toomas > Begin forwarded message: > > From: Toomas Soome via Review Board <devn...@illumos.org> > Subject: Review Request 1225: zio_free_sync() should recognize gang block size > Date: 7 October 2018 at 10:26:03 EEST > To: Joshua Clulow <j...@sysmgr.org>, Vitaliy Gusev > <gusev.vita...@icloud.com>, Marcel Telka <mar...@telka.sk>, Toomas Soome > <tso...@me.com>, Andy Fiddaman <omn...@citrus-it.co.uk>, carlos neira > <cneirabus...@gmail.com>, Juraj Lutter <ju...@lutter.sk>, Dan Vatca > <d...@syneto.net>, John Howard <echosoft....@gmail.com>, Norm Jacobs > <n...@snapcon.com>, Albert Lee <tr...@nexenta.com> > Reply-To: Toomas Soome <tso...@illumos.org> > > This is an automatically generated e-mail. To reply, visit: > https://www.illumos.org/rb/r/1225/ <https://www.illumos.org/rb/r/1225/> > Review request for general. > By Toomas Soome. > Repository: illumos-gate > Description > > the zio_free_sync() in illumos tree does not recognize gang block size > while freebsd does via passing extra size argument > (http://src.illumos.org/source/xref/freebsd-head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c#997). > > Using extra argument there seems like unneeded overhead, we can use > BP_IS_GANG() to select between SPA_GANGBLOCKSIZE and BP_GET_PSIZE(bp) in > zio_free_sync() and avoid introducing size argument. > Diffs > > usr/src/uts/common/fs/zfs/zio.c (b7e11f922a9569fdbea185810afa2360375c299c) > View Diff <https://www.illumos.org/rb/r/1225/diff/1/> ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/T398b23af1f0a2efe-Ma878fa4e146325ec5608e9e5 Delivery options: https://openzfs.topicbox.com/groups/developer/subscription
