On 17/05/2019 01:55, Sean Fagan wrote:
On May 16, 2019, at 11:33 AM, Matthew Ahrens <[email protected]> wrote:
      • Igor: There have been issues when root pools are expecting compression 
to be disabled (on SPARC?)
      • Allan: This has been the default in FreeBSD installer for ~2 years
      • Sef: Boot pools need to be different for each platform, but grub 
doesn’t seem like it needs to be different. Sef supports it being the default.
      • Compression=on has been the default in FreeNAS for several years; no 
complaints
      • *** Someone to take an action item to investigate benefits and issues, 
and write it up? (Matt will put out a call for someone to take ownership of 
this)
openzfs / openzfs-developer / see discussions + participants + delivery options 
Permalink

So, unless I’m missing something, this is pretty trivial:
diff --git a/include/sys/zio.h b/include/sys/zio.h
index e69bf9208039..461cc8232394 100644
--- a/include/sys/zio.h
+++ b/include/sys/zio.h
@@ -140,7 +140,7 @@ enum zio_encrypt {
 #define        ZIO_COMPRESS_LEGACY_ON_VALUE    ZIO_COMPRESS_LZJB
 #define        ZIO_COMPRESS_LZ4_ON_VALUE       ZIO_COMPRESS_LZ4

-#define        ZIO_COMPRESS_DEFAULT            ZIO_COMPRESS_OFF
+#define        ZIO_COMPRESS_DEFAULT            ZIO_COMPRESS_LZ4

 #define        BOOTFS_COMPRESS_VALID(compress)                 \
        ((compress) == ZIO_COMPRESS_LZJB ||             \

That would set it to LZ4 by default; this is slightly different from using 
"compress=on" when creating a pool or dataset.

Other than documentation changes, did I miss something? :)

Do the zpool and zfs list commands have the options to show compressed
and uncompressed sizes for pools/filesystems/snapshots ?
--
Dr.Udo Grabowski   Inst.f.Meteorology & Climate Research IMK-ASF-SAT
http://www.imk-asf.kit.edu/english/sat.php
KIT - Karlsruhe Institute of Technology           http://www.kit.edu
Postfach 3640,76021 Karlsruhe,Germany T:(+49)721 608-26026 F:-926026

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


------------------------------------------
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/Tcfdc8da2da71e1c0-Mc874d1f417d64ec7741e32d4
Delivery options: https://openzfs.topicbox.com/groups/developer/subscription

Reply via email to