> On Nov. 16, 2014, 4:02 p.m., Richard Elling wrote: > > usr/src/uts/common/fs/zfs/dsl_scan.c, line 432 > > <https://reviews.csiden.org/r/136/diff/1/?file=11708#file11708line432> > > > > since we don't have to be very precise here, rather than divide, is it > > ok to shift >> 30?
I think a divide operation for every scrub i/o will not be impact performance measurably. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/136/#review328 ----------------------------------------------------------- On Nov. 16, 2014, 3:37 p.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/136/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2014, 3:37 p.m.) > > > Review request for OpenZFS Developer Mailing List. > > > Bugs: 5351 and 5352 > https://www.illumos.org/projects/illumos-gate//issues/5351 > https://www.illumos.org/projects/illumos-gate//issues/5352 > > > Repository: illumos-gate > > > Description > ------- > > 5351 scrub goes for an extra second each txg > 5352 scrub should pause when there is some dirty data > Reviewed by: Christopher Siden <christopher.si...@delphix.com> > Reviewed by: George Wilson <george.wil...@delphix.com> > Reviewed by: Alex Reece <alex.re...@delphix.com> > > Original author: Matthew Ahrens > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/dsl_scan.c > 2392b7f336952a2cc9dbf4983f8f83c5fc53d9a8 > > Diff: https://reviews.csiden.org/r/136/diff/ > > > Testing > ------- > > ztest > zfs test suite > manual testing of scrub times > > (internal link: http://jenkins/job/zfs-precommit/1140/) > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer
